fix(TabViewItemDirective ): textTransform property added #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
textTransform property added to TabViewItemDirective so that in angular tabItem textTransformation can be changed.
textTransform property to TabViewItemDirective
ghost
added
the
removed tailing whitespace which was causing build failed.
bhavincb
changed the title
|
unable to see details of failed check. |
|
@bhavincb Some tests failed that don't seem to have anything to do with this PR. We are taking a look. |
|
test |
MartoYankov
approved these changes
May 21, 2018
|
test |
sis0k0
pushed a commit
that referenced
this pull request
May 23, 2018
An issue came out of #1315. TabViewItem textTransform has a default value for Android that kick in only if no value (even a null value) is set. Note: Will need to change an image in the ui tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
currently
TabViewItemDirectiveonly acceptstitleandiconSourceas input nottextTransformWhat is the new behavior?
added
textTransformproperty to TabViewItemDirectiveFixes/Implements/Closes #[Issue Number].
#1312