Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): default to unsetValue for value accessors #846

Merged
merged 1 commit into from
Oct 11, 2017
Merged

fix(forms): default to unsetValue for value accessors #846

merged 1 commit into from
Oct 11, 2017

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Jun 14, 2017

@vakrilov
Copy link
Contributor

Is it possible to add a unit test for this?
Overall [ng-model]/value-accessor seem to break from time to time. Let's try to make a proper example which can be tested with e2e tests and can be used as reference for clients.

@NativeScript NativeScript deleted a comment from SvetoslavTsenov Jun 30, 2017
@NativeScript NativeScript deleted a comment from SvetoslavTsenov Jun 30, 2017
@sis0k0 sis0k0 self-assigned this Jul 5, 2017
@sis0k0 sis0k0 added this to the 3.2 TBD milestone Jul 5, 2017
@sis0k0 sis0k0 mentioned this pull request Aug 16, 2017
Closed
@dtopuzov
Copy link
Contributor

run ci

@ghost ghost added the in progress label Sep 28, 2017
@sis0k0
Copy link
Contributor Author

sis0k0 commented Sep 28, 2017

uitests

@ghost ghost assigned vakrilov Oct 10, 2017
@vakrilov
Copy link
Contributor

Resolves #943

@vakrilov
Copy link
Contributor

Rebased onto master

@vchimev
Copy link
Contributor

vchimev commented Oct 11, 2017

sdkwebpack

@vakrilov vakrilov merged commit 6940955 into master Oct 11, 2017
@vakrilov vakrilov deleted the vlaeva/unset-value branch October 11, 2017 08:50
@ghost ghost removed the in progress label Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

Assignees

@vakrilov vakrilov

@sis0k0 sis0k0

Labels
None yet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sis0k0 @vakrilov @dtopuzov @vchimev