Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI does not generate all icons #5126

Closed
rosen-vladimirov opened this issue Nov 13, 2019 · 11 comments
Closed

CLI does not generate all icons #5126

rosen-vladimirov opened this issue Nov 13, 2019 · 11 comments
Assignees
Milestone

Comments

@rosen-vladimirov
Copy link
Contributor

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.2.0
  • Cross-platform modules: Not applicable
  • Android Runtime: Not applicable
  • iOS Runtime: Not applicable
  • Plugin(s): Not applicable

Describe the bug
When executing tns resources generate icons <my_icon.png>, CLI 6.2.0 shows several warnings and does not generate some of the icons:

Didn't find a matching image definition for file AppIcon.appiconset\icon-20@2x.png. This file will be skipped from reources generation.
Didn't find a matching image definition for file AppIcon.appiconset\icon-20@3x.png. This file will be skipped from reources generation.
Didn't find a matching image definition for file AppIcon.appiconset\icon-20.png. This file will be skipped from reources generation.
Didn't find a matching image definition for file AppIcon.appiconset\icon-20@2x.png. This file will be skipped from reources generation.

CLI 6.1.x works correctly in this case.

To Reproduce

  1. Install CLI 6.2.0 (npm i -g nativescript@6.2.0)

  2. Create new project: tns create myApp --js

  3. Navigate to the project: cd myApp

  4. Try to generate icons: tns resources generate icons <some_icon.png>
    You'll see warnings

  5. Check App_Resources\iOS\Assets.xcassets\AppIcon.appiconset - three of the icons are not replaced.

Expected behavior
CLI should generate all icons.

Sample project

Additional context

@EdJones
Copy link

EdJones commented Nov 15, 2019

I can confirm this behavior in Sidekick on Window 10.
I have tns-core-modules 6.2.1 installed.

Can this be what is giving the the dread "Spawn error" when uploading to Apple?

@rosen-vladimirov rosen-vladimirov self-assigned this Nov 15, 2019
@ritasumtsova
Copy link

Can this be what is giving the the dread "Spawn error" when uploading to Apple?

I have the same issue
drives me crazy!

@EdJones
Copy link

EdJones commented Nov 15, 2019

Can this be what is giving the the dread "Spawn error" when uploading to Apple?

I have the same issue
drives me crazy!

Rita, did you check your logs (Sidekick menu>Help>Show Logs). Sometimes this helps.

Also, I have opened an issue to help developers deal with the cryptic Spawn error message:
ProgressNS/sidekick-feedback#441

@ritasumtsova
Copy link

Rita, did you check your logs (Sidekick menu>Help>Show Logs). Sometimes this helps.

Yeap, I checked it. I updated everything in my project and expected all is going to be fine, but now I have this one #5141

@rosen-vladimirov rosen-vladimirov modified the milestones: 6.2.1, 6.2.2 Nov 18, 2019
@dtopuzov dtopuzov closed this as completed Jan 7, 2020
@DecentGradient
Copy link

I'm having this exact issue in version 6.7.4

@NathanaelA

This comment was marked as abuse.

@DecentGradient
Copy link

@NathanaelA Using NS cli, thanks for the tip

@NathanaelA

This comment was marked as abuse.

@DecentGradient
Copy link

DecentGradient commented Jun 17, 2020 via email

@DecentGradient
Copy link

hmm it works, only thing i did is reinstall NS globally 🤷

@DecentGradient
Copy link

Thanks for your responsiveness and making me feel welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants