Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running postinstall scripts when adding a plugin #2944

Closed
wants to merge 1 commit into from
Closed

Allow running postinstall scripts when adding a plugin #2944

wants to merge 1 commit into from

Conversation

EddyVerbruggen
Copy link
Contributor

Fixes #2521 again.

@dtopuzov
Copy link
Contributor

dtopuzov commented Jul 4, 2017

run ci

@rosen-vladimirov
Copy link
Contributor

Hey @EddyVerbruggen ,
Please excuse me for the late reply. Thank you for this PR. The current fix will trigger double npm install, which is not exactly the desired effect.
However, I've found another way to handle this and I've created a PR, you can take a look at it here.
I'll close this PR, again thank you for your efforts.

We'll release the fix as soon as possible,

@EddyVerbruggen
Copy link
Contributor Author

You're the best, thanks a bunch for the swift response! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EddyVerbruggen @dtopuzov @rosen-vladimirov