Remove Inspector WebSocket #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspector websocket crashes when the message is too big so use a tcp socket instead
|
Can one of the admins verify this patch? |
| allowHalfOpen: true | ||
| }); | ||
|
|
||
| server.listen(socketFileLocation); |
There was a problem hiding this comment.
I think this code has a potential for race condition. The server starts listening before the callback for on connection is set. Should we move this call after the server.on calls?
There was a problem hiding this comment.
Will move it :)
|
Your comments are addressed |
|
👍 |
1 similar comment
|
👍 |
|
I'm merging this as it has been approved and the respective change in ios runtime is already merged |
rosen-vladimirov
added a commit
that referenced
this pull request
Sep 23, 2015
Remove Inspector WebSocket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspector websocket crashes when the message is too big so use a tcp socket instead
The corresponding PR in ios-runtime is NativeScript/ios-jsc#317