Fix datetimepicker not opening on versions below iOS 14 #79
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
| @@ -189,7 +189,7 @@ export class DateTimePicker extends DateTimePickerBase { | |||
| } | |||
| if (color) { | |||
| if (this.SUPPORT_TEXT_COLOR) { | |||
| nativePicker.setValueForKey(color, 'textColor'); | |||
| nativePicker.setValueForKey(color.ios, 'textColor'); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
we are on NS 6.5.20 actually !
The application crashes instantly, but sentry does catch an error for us:
[TNSDictionaryAdapter set]: unrecognized selector sent to instance 0x28239bdc0
There was a problem hiding this comment.
It was my fault. I removed ".ios" on my last PR.
I'm sorry.
|
Hello there ! Any update on this ? Many thanks |
|
Could you please merge this PR @NathanaelA ? |
Fix #78
Tested and confirmed working on a simulation iPhone 6s on iOS 12.4 and 14.0