Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datetimepicker not opening on versions below iOS 14 #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix datetimepicker not opening on versions below iOS 14 #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datetimepicker.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export class DateTimePicker extends DateTimePickerBase {
}
if (color) {
if (this.SUPPORT_TEXT_COLOR) {
nativePicker.setValueForKey(color, 'textColor');
nativePicker.setValueForKey(color.ios, 'textColor');

This comment was marked as abuse.

Sign in to view

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are on NS 6.5.20 actually !
The application crashes instantly, but sentry does catch an error for us:

[TNSDictionaryAdapter set]: unrecognized selector sent to instance 0x28239bdc0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my fault. I removed ".ios" on my last PR.
I'm sorry.

}
nativePicker.setValueForKey(false, "highlightsToday");
}
Expand Down