Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Can not transpile tns-core-modules with nativescript-dev-webpack #932

Closed
vchimev opened this issue Jun 11, 2019 · 0 comments
Closed

Can not transpile tns-core-modules with nativescript-dev-webpack #932

vchimev opened this issue Jun 11, 2019 · 0 comments
Assignees
Labels

Comments

@vchimev
Copy link
Contributor

vchimev commented Jun 11, 2019

Describe the bug

The xml-namespace-loader requires the tns-core-modules/xml module.

Respectively, the tns-core-modules package is dependency of nativescript-dev-webpack without referenced in the package.json file.

This restricts transpiling tns-core-modules via nativescript-dev-webpack as the tns-core-modules/xml module is not available at time it is required.

To Reproduce

git clone -b bundle-workflow https://github.com/NativeScript/NativeScript.git
cd NativeScript && npm install
cd ../tns-core-modules && npm install
cd ../tests && npm install
tns run android|ios

Additional context

Output:

file:///app/bundle.js:56316:897: JS ERROR Error: Module build failed (from ../node_modules/nativescript-dev-webpack/xml-namespace-loader.js):
Error: Cannot find module '/Users/vchimev/Downloads/NativeScript/tests/node_modules/tns-core-modules/xml/xml'. Please verify that the package.json has a valid "main" entry
vchimev added a commit to NativeScript/NativeScript that referenced this issue Jun 11, 2019
This commit:
- adds `tns-core-modules/xml/xml.js` to source control as required by `nativescript-dev-webpack`:
NativeScript/nativescript-dev-webpack#932
- configures the `tsconfig.json` file of tests
- delete irrelevent steps from the development workflow instructions
vchimev added a commit to NativeScript/NativeScript that referenced this issue Jun 11, 2019
This commit:
- adds `tns-core-modules/xml/xml.js` to source control as required by `nativescript-dev-webpack`:
NativeScript/nativescript-dev-webpack#932
- configures the `tsconfig.json` file of tests
- deletes irrelevent steps from the development workflow instructions
vchimev added a commit to NativeScript/NativeScript that referenced this issue Jun 12, 2019
This commit:
- adds `tns-core-modules/xml/xml.js` to source control as required by `nativescript-dev-webpack`:
NativeScript/nativescript-dev-webpack#932
- configures the `tsconfig.json` file of tests
- deletes irrelevent steps from the development workflow instructions
vchimev added a commit to NativeScript/NativeScript that referenced this issue Jun 13, 2019
This commit:
- adds `tns-core-modules/xml/xml.js` to source control as required by `nativescript-dev-webpack`:
NativeScript/nativescript-dev-webpack#932
- configures the `tsconfig.json` file of tests
- deletes irrelevent steps from the development workflow instructions
vakrilov pushed a commit to NativeScript/NativeScript that referenced this issue Jun 17, 2019
This commit:
- adds `tns-core-modules/xml/xml.js` to source control as required by `nativescript-dev-webpack`:
NativeScript/nativescript-dev-webpack#932
- configures the `tsconfig.json` file of tests
- deletes irrelevent steps from the development workflow instructions
@vakrilov vakrilov self-assigned this Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants