Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OpenGL rendering by default in Engine #801

Conversation

YakoYakoYokuYoku
Copy link
Member

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Breaking change (fix or feature that would cause existing functionality to change)

What does this pull request do?

Currently Natron by default disables GPU rendering if running in background, i.e. NatronRenderer, this results in effects not being able to use it and in cases that OpenGL is required the plugin may throw an exception or crash (see this issue comment for more details).
A way to fix this is to enable it by default so environments that load OpenGL in a suitable way for Natron can make use of it, even if Natron isn't windowed.
In case there's a much better solution out there then this PR could be superseded by another one.

Show a few screenshots (if this is a visual change)

N/A.

Have you tested your changes (if applicable)? If so, how?

By rendering a project that uses the Shadertoy plugin with both Natron and NatronRenderer.

Futher details of this pull request

Attempts to fix #779.

@devernay
Copy link
Member

see comment in #779 (comment)

@YakoYakoYokuYoku
Copy link
Member Author

Closing per request in #779.

@YakoYakoYokuYoku YakoYakoYokuYoku deleted the enable-rendering branch June 18, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Bug): check why OpenGL rendering is disabled in NatronRenderer
2 participants