stopNodes not in type definitions yet

[sverweij]

Checklist

• Have you asked your question on Stackoverflow or similar forum?
• Are you running the latest version?
• Have you included sample input, output, error, and expected output?
• Have you checked if you are using correct configuration?
• Did you try online tool? (N/A I think?)

Input

Code

import fastxml from 'fast-xml-parser';

function parse(pXMLString: string): any {
  if (fastxml.validate(pXMLString) === true) {
    return fastxml.parse(pXMLString, {
      attributeNamePrefix: '',
      ignoreAttributes: false,
      stopNodes: ['onentry', 'onexit', 'transition'],
    });
  }
  throw new Error("That doesn't look like valid xml ...\n");
}

Output

When compiling the code, the typescript compiler complains stopNodes doesn't exist on Partial<X2jOptions>.

(Demo repo over here npm i && npm run build to reproduce)

Root cause seems that X2jOptions in src/parser.d.ts doesn't yet contain the stopNodes attribute that was introduced in #150.

src/parseit.ts:8:7 - error TS2345: Argument of type '{ attributeNamePrefix: string; ignoreAttributes: false; stopNodes: string[]; }' is not assignable to parameter of type 'Partial<X2jOptions>'.
  Object literal may only specify known properties, and 'stopNodes' does not exist in type 'Partial<X2jOptions>'.

8       stopNodes: ['onentry', 'onexit', 'transition'],
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error.

expected data

The code compiles without warnings.

Would you like to work on this issue?

• Yes
• No