Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(types): add stopNodes to X2jOptions #192

Merged
merged 1 commit into from
Oct 5, 2019
Merged

bugfix(types): add stopNodes to X2jOptions #192

merged 1 commit into from
Oct 5, 2019

Conversation

sverweij
Copy link
Contributor

@sverweij sverweij commented Oct 4, 2019

Purpose / Goal

  • Adds the stopNodes attribute to the X2jOptions in src/parser.d.ts so they can be used in typescript projects without the typescript compiler complaining (and ide's can autocomplete them).

Fixes #191

Type

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

so they can be used cleanly in typescript.

Fixes #191
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.309% when pulling b8167d6 on sverweij:bugfix/add-stopnodes-to-type-definition into 322f13d on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit 4a49683 into NaturalIntelligence:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stopNodes not in type definitions yet
3 participants