Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jObj.hasOwnProperty is not a function #613

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

ardatan
Copy link
Contributor

@ardatan ardatan commented Sep 27, 2023

Purpose / Goal

If the given object has null prototype instead of Object, it throws jObj.hasOwnProperty is not function error.
Object.prototype.hasOwnProperty.call( should be used instead for this kind of objects.

Type

Please mention the type of PR

  • [x]Bug Fix
  • [ ]Refactoring / Technology upgrade
  • [ ]New Feature

Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend [WIP] in PR title. Your PR will be reviewed when [WIP] will be removed from the PR title.

Bookmark this repository for further updates.

@coveralls
Copy link

Coverage Status

coverage: 98.248%. remained the same when pulling 085defa on ardatan:patch-1 into 9504fac on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit 5d00ecf into NaturalIntelligence:master Oct 1, 2023
7 checks passed
@ardatan ardatan deleted the patch-1 branch October 1, 2023 15:28
@ardatan
Copy link
Contributor Author

ardatan commented Oct 1, 2023

Thanks for merging the PR! @amitguptagwl When do you think you can release it?

@amitguptagwl
Copy link
Member

Sorry, I completely missed it. just published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants