Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert when switching wallet storage option to none #458

Merged
merged 1 commit into from Jul 29, 2021
Merged

Alert when switching wallet storage option to none #458

merged 1 commit into from Jul 29, 2021

Conversation

Joohansson
Copy link
Member

The user needs to approve that the wallet seed is saved. Setting storage to none means there will be no wallet on the next reload.

Fixes #428

  • Alert will display when user press the save button
  • Pressing OK will save the settings
  • Pressing Cancel will revert the storage option and interrupt saving (and notify the user)

image

@Joohansson
Alert when switching wallet storage option to none
6e9344f 
The user need to approve that wallet seed is saved
@Joohansson Joohansson added the enhancement New feature or request label Jul 27, 2021
@Joohansson Joohansson requested a review from keerifox July 27, 2021 17:02
@BitDesert BitDesert merged commit ed47785 into master Jul 29, 2021
@BitDesert BitDesert deleted the wallet-storage-alert branch July 29, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keerifox keerifox keerifox approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing alert when changing Wallet Storage option
3 participants
@Joohansson @keerifox @BitDesert