Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatching percentages in representative health tooltip #589

Merged
merged 1 commit into from Aug 14, 2023

Conversation

keerifox
Copy link
Member

Text error introduced in #457 (transloco localization)

Source for 2% and 3% being in use in the code:

if (percent.gte(3)) {
status = 'alert'; // Has extremely high voting weight
repStatus.veryHighWeight = true;
repStatus.changeRequired = true;
} else if (percent.gte(2)) {
status = 'warn'; // Has high voting weight
repStatus.highWeight = true;
}

@keerifox
Copy link
Member Author

example of the issue

image

@Joohansson Joohansson merged commit c68d78e into Nault:master Aug 14, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants