Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix api support #267

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Helix api support #267

wants to merge 19 commits into from

Conversation

zm3y
Copy link
Contributor

@zm3y zm3y commented Feb 16, 2022

This is my try to migrate this extension to Helix api. Maby it had some bugs idk.

What work:

  • Authorisation
  • Notifications & Notification settings
  • Top games (now twitch call it as categories) and view streams by category
  • Top streams
  • Channels search
  • Filter by language and name

What removed/changed/problems:

  • Removed Followed games (removed from api)
  • Removed Vodcast/rerun check (helix api dont have this info O_o, this is strange)
  • Bug Pagination/load more streams (work only on notification settings)
  • No channel logos in notification settings & offline channels (need to do request for each logo, but rate limit only 30 in 1 min)
  • No info (viewers & channels couter) about top categories (api dont have this info)
  • Removed videos from category view (api send emty or very old videos)
  • Follow/unfollow dont work (removed from api)

@nthnwllms
Copy link

nthnwllms commented Feb 16, 2022

Amazing work 👏

I built it and it looks to be working, even with the v5 API being down at the moment

image

I'll continue to use this and test. I don't use features like notifications, I only use it to see the number of streams that are live and access them but I'll experiment a bit. Thank you very much for your work :)

@Abalieno
Copy link

Abalieno commented Feb 16, 2022

Can you fork this and republish?

Because I don't think this is being maintained... Maybe it doesn't need any compilation or similar and can just be installed manually (it seems it needs to be built).

@volutus
Copy link

volutus commented Feb 16, 2022

I cloned the repo to test and these changes are working for me during the current planned Kraken outage. Nice work!

image

@Yames24
Copy link

Yames24 commented Feb 17, 2022

Good stuff! Once I figured out how to build the extension, it works like it did before.

@TheKins
Copy link

TheKins commented Feb 17, 2022

Figured out how to build it and it works pretty darn well! Stellar work!

Probably worth a proper fork and re-release on the various stores if the official version doesn't get an update.

@TheKins
Copy link

TheKins commented Feb 17, 2022

Filing a possible bug report: Streams appear to always be sorted by viewer count even when the "Sort streams by" setting is changed:

image
image

@zm3y
Copy link
Contributor Author

zm3y commented Feb 17, 2022

@TheKins forgot about this, thank you, fixed

@TheKins
Copy link

TheKins commented Feb 17, 2022

Good lord that was quick. Fix seems to work great, thanks so much for doing all this!

@Baatho
Copy link

Baatho commented Feb 17, 2022

Compiled to try out from the repository on your page, and have found a bug? (unsure if it's an API issue or extension issue) - streamers with a non-capital letter at the start of their name are being sorted after the capital letters, instead of with them (sorted by title A-Z ofc)

Old, live extension:
image

Your Helix fix:
image

edit: pulled and merged the OG extension and this pull, same issue, just in case there was something else at play

@zm3y
Copy link
Contributor Author

zm3y commented Feb 17, 2022

@qzfive yep, you're right, it's bug. Fixed.

@Baatho
Copy link

Baatho commented Feb 17, 2022

That was fast, awesome! Thank you very much for fixing this extension for the new API, it's (imo) by far the best one of its type

@TheKins
Copy link

TheKins commented Feb 19, 2022

Another bug report: Sometimes when a channel goes live, it pops up without a name or viewer count and a blank notification. These details return once the list is refreshed.

image
image

@zm3y
Copy link
Contributor Author

zm3y commented Feb 19, 2022

@TheKins I know about this. But when I try catch it, noticed, It was real data from Helix. They return empty user_name field. I keep investigating, maby my fault.

Up to 60sec after stream start Helix api return empty capitalized streamer name. So we can use streamer login name instead of nothing. Nobody mind?
@noviceg
Copy link

noviceg commented Feb 22, 2022

image
niiiice, zm3y is our savior

@ExorcistF1
Copy link

I have no idea how to build the extension, but i need one

@itsavaren
Copy link

Please note that the current implementation leaks the Client Secret of the Application. This is a Security Vulnerability and allows anyone to create Tokens on behalf of it and Spam the API to death with the Application being at fault.

It should be looked into removing the Client Secret from the Repository by utilizing the Implicit Auth Flow instead, which does not require the Secret.

guessing someone took your advice :(

@jannickj
Copy link

any chance of someone fixing it? :D

@noviceg
Copy link

noviceg commented Mar 30, 2022

we need a hero

@Zachruff
Copy link

fingers crossed for a fix

@kevinmon91
Copy link

I hope somebody can fix it!

@jason-e
Copy link

jason-e commented Mar 30, 2022

Please note that the current implementation leaks the Client Secret of the Application. This is a Security Vulnerability and allows anyone to create Tokens on behalf of it and Spam the API to death with the Application being at fault.

It should be looked into removing the Client Secret from the Repository by utilizing the Implicit Auth Flow instead, which does not require the Secret.

The extension has used Implicit Auth Flow for a long time, it seems the client secret was just never removed.

@Dittmen111
Copy link

It doesnt work . I cant log in twitch now and error occurs {"status":500,"message":"invalid authorization"}
Please help us ..

@zm3y
Copy link
Contributor Author

zm3y commented Mar 30, 2022

Hello guys. I'm alive, but who cares :)
I think twitch just disable @Ndragomirov client_id. I change it to new and it work well.
@1eft0ver Thank you for you find out. Added to last build.
Chrome build : twitch-now-1.1.221-github-helix-build-chrome.zip
Firefox build : twitch-now-1.1.221-github-helix-build-firefox.zip (Pls, anyone, sign this for other people, thank you!)

@noviceg
Copy link

noviceg commented Mar 30, 2022

It works! Thank you @zm3y, stay safe!

@Temet79
Copy link

Temet79 commented Mar 30, 2022

Thank you @zm3y !

@jannickj
Copy link

thanks @zm3y glad to hear you're still alive! 😁

@vaindil
Copy link

vaindil commented Mar 30, 2022

Thank you for the update! Here's the signed Firefox build.

twitch_now_github_helix_build-1.1.221-an+fx.xpi.zip

@zm3y
Copy link
Contributor Author

zm3y commented Mar 30, 2022

I think I should say this. We all love this extension. It is what we are use. But we need to accept what happened. This extension is dead. I advise everyone to try Gumbo: Twitch Companion. This is a completely new extension from one of the Twitch-Now contributors @Seldszar . Yes, it might be missing something. But it is being actively developed. It looks very similar and intuitive. Just try. Thank you all, good luck and take care of yourself.

@Morten79
Copy link

Thanks alot for taken your time getting this extension working again and very happy to hear you're still alive. I wish you all the best.
I'll take a looks at Gumbo: Twitch Companion it seems like a really good alternative / replacement.
Take care and good luck 💙💛

@ghost
Copy link

ghost commented Mar 31, 2022

Gumbo is by far the best alternative to twitch now.

@nad53
Copy link

nad53 commented Apr 1, 2022

great job there to keep functional this plugin !

Only issue I have found is that whenever I open up Firefox in morning, I have to click on refresh for the plugin to load up in list all streams that are still online. If I close firefox and re open it, then the streams still show up on the list.

Does this have a way to be fixed ? If not, could be added up as a possible bug fix ?

@NeikoNe
Copy link

NeikoNe commented Apr 6, 2022

Hi, Todaz, the extension is showing error page:
image

Any ideas about what could be causing it?

Thx for keeping this extension working!!

@DimasDSF
Copy link

DimasDSF commented Apr 6, 2022

Hi, Todaz, the extension is showing error page:
image

Any ideas about what could be causing it?

Thx for keeping this extension working!!

Did you delete the folder after loading the extension? You need to keep the folder for it to work

@NeikoNe
Copy link

NeikoNe commented Apr 6, 2022

I have not moved it or removed any files but downloading again and adding it into the browser works. Strange... Thx for the suggestion!

@y0rune
Copy link

y0rune commented Apr 15, 2022

Thank you for the update! Here's the signed Firefox build.

twitch_now_github_helix_build-1.1.221-an+fx.xpi.zip

I would like to install it on the Windows, and I have issue.
obraz

@GVegaZ
Copy link

GVegaZ commented Apr 26, 2022

i was using this extension since 2014(6) and as much I hate changes I think is time to move on 😢

@y0rune
Copy link

y0rune commented Apr 26, 2022

I sadly started to use the gumbo.

@jannickj
Copy link

😭

@DanzoGit
Copy link

I don't like the Gumbo.. There are no sound notifications..

@Dracconis
Copy link

I am having the same issue as NeikoNe and the issue is that when chrome is closed or has an update, the extension folder gets removed from %APPDATA%\Local\Google\Chrome\User Data\Profile 1\Extensions and therefore renders the extension useless. You have to reinstall the extension each and every time this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.