Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting example for Version elements #208

Closed
skinkie opened this issue Jul 27, 2021 · 5 comments
Closed

Conflicting example for Version elements #208

skinkie opened this issue Jul 27, 2021 · 5 comments
Assignees
@ue71603
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Milestone
netex_1.2

Comments

@skinkie
Copy link
Contributor

skinkie commented Jul 27, 2021

In the current NeTEx example section the following examples for the Version element have been elaborated. The key takeaway seems to be that the DataSource@version-attribute directly refers to the Version@id-attribute.

image

This is in contrast with the CEN documentation which suggests that the ScheduledStopPoint@version-attribute, refers to the Version@version-attribute.

image
@skinkie skinkie added bug Technical mistake, inconsistency with the documentation, etc. needs-example This change should have an XML how it is used, and monitored via CI. needs documentation update The NeTEx document needs to be updated labels Jul 27, 2021
@Aurige
Copy link
Contributor

Aurige commented Aug 17, 2021

The first example seems to be very specific the the NPTG context and its internal organisation. It's very specific but still valid against the general NeTEx rules for versions.
I don't see a bug here : maybe some additional info & links about NPTG should be provided.

@ue71603 ue71603 added this to the netex_1.3 milestone Apr 19, 2022
@ue71603
Copy link
Contributor

ue71603 commented Apr 21, 2022

Change any in the example.

@ue71603 ue71603 removed needs-example This change should have an XML how it is used, and monitored via CI. needs documentation update The NeTEx document needs to be updated to be discussed labels Apr 21, 2022
@ue71603 ue71603 self-assigned this Apr 21, 2022
@ue71603 ue71603 modified the milestones: netex_1.3, netex_1.2 Apr 21, 2022
@Aurige
Copy link
Contributor

Aurige commented Oct 17, 2023

see #471

@ue71603
Copy link
Contributor

ue71603 commented Dec 12, 2023

@Aurige when all is done in #471 can I close it here?

@Aurige
Copy link
Contributor

Aurige commented Dec 12, 2023

fixed by #471

@Aurige Aurige closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ue71603 ue71603

Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Milestone
netex_1.2
Development

No branches or pull requests
4 participants
@skinkie @nick-knowles @Aurige @ue71603