Required IdType fixes #471

skinkie · 2023-07-26T17:56:44Z

This pull request tries to address the missing required "id" attributes. This is selected by:

GeneralFrameMembers (they must have id, no question)
Keyrefs that are already modelled in the NeTEx_publication file

I may have added too many, which I certainly will review. For the following objects there are IdTypes defined, but there is no individual id attribute modelled, this should still be done.

CustomerService
Entrance
FareContractEntry_
GeneralFrameMember
OtherOrganisation
PassengerCarryingRequirementsView
PassingTimeView
Point
ServiceAccessRight_
SignEquipment
TravelSpecification_
TypeOfEntity
VehicleMeetingPlace_
Zone

PassingTimeView and PassengerCarryingRequirementsView are likely a bug in the schema that introduces them in the GeneralFrame. For PassingTimeView a DataManagedObjectView is first introduced, and never used after. For PassengerCarryingRequirementsView in my guess invalidly a DataManagedObject is used (see: #474)

skinkie · 2023-07-26T18:36:18Z

Failing examples must be fixed. Already checked with the cardinality in the documentation.

something went massively wrong...

This reverts commit f7997ad.

This reverts commit 2b466ef.

This reverts commit 20e6fd6.

ue71603 · 2023-07-28T10:46:58Z

xsd/netex_part_1/part1_ifopt/netex_ifopt_site_version.xsd

 		</xsd:annotation>
+		<!-- TODO: Matthias


Adding all this stuff is no good idea. It is already there in Entrance before. That is why the ambiguity occurs.
An id is also there:

Is the problem that it is not required?

What we try to achieve here is that the attribute id gets overridden later with a specific ObjectIdType for that specific element. Theoretically we could add a regular expression then that would guard that the object is named like "codespace:ScheduledStopPoint:something". Not my intention now, but building the relationship between Ref and Id is.

…TEx-CEN/NeTEx into fix_attribute_id_use_required

skinkie · 2023-07-28T10:59:42Z

xsd/netex_part_1/part1_ifopt/netex_ifopt_site_version.xsd

@@ -483,7 +483,7 @@ Rail transport, Roads and Road transport
 			</xsd:extension>
 		</xsd:complexContent>
 	</xsd:complexType>
-	<xsd:element name="VehicleEntrance" abstract="true" substitutionGroup="Entrance">
+	<xsd:element name="VehicleEntrance" abstract="true" substitutionGroup="SiteComponent">


This kills the method resolution order (MRO) of the schema. Hence VehicleEntrance will be at the same level as Entrance, while what we want is having the inheritance.

I think we have a problem already, because Entrance comes from SITE and VehicleEntrance probably should not be a SITE. Or do I read this wrong?

It also might be one of the cases where we need an Entrance_ . Because having to restrictions in a row is not allowed in the inheritance. Should I try to model an Entrance_? According to one of the examples?

Or we should do the inheritance through the VersionStructure elements. I think that only in the "leaves" the id stuff can be done once.

I think this is a case where Entrance_ would make sense. In this situation I also want to figure out why (or not) Entrance_ may (or may not) be abstract.

…TableColumn has a required order element

ue71603 · 2023-07-29T16:25:49Z

fixed all assigned tasks

skinkie · 2023-08-03T11:05:40Z

xsd/NX.xsd

@@ -37,7 +37,7 @@
 						<xsd:element name="points" minOccurs="0">
 							<xsd:complexType>
 								<xsd:sequence>
-									<xsd:element ref="Point" maxOccurs="unbounded"/>
+									<xsd:element ref="Point_" maxOccurs="unbounded"/>


Are you sure about these changes? It feels like you are referencing to 'abstract' datatypes / 'containers'.

I am an engineer (not true): It works... And it seems to me that they did it that way on other xxx_ elements. What it does it references the "concrete" element that is used in the substitutionGroup. Otherwise it wouldn't work. But to be sure we would need a comment from Nick or Christophe.

@nick-knowles @Aurige

This is a bit different from the topic of the PR ;-) but technically should be Ok: I think that this is replacing a ref to anything inheriting from Point to anything being of in the Point_ substitution group. I didn't check the possible semantic impact (yet).

Aurige · 2023-09-06T17:40:06Z

I'm not sure that we can be so systematic ! A commented in other PR, I agree that any standalone object that can be referenced should be enforced to have an Id, but when it's an object that is embedded in the XML hierarchy and that will never be referenced, this constraint does not really makes sense (also it is harmless ... except that it brakes existing data).
For example, take the very first example you had to update : the <LimitingRuleInContext> is embedded, and giving it an Id is a constraint that is useless.
I will add this as a discussion point fir next meeting.

More required IdType fixes

4ec8571

skinkie added the enhancement non semantic enhacement: technical enhancement, etc. label Jul 26, 2023

skinkie requested review from nick-knowles, Aurige, ue71603 and trurlurl July 26, 2023 17:56

skinkie self-assigned this Jul 26, 2023

skinkie added 3 commits July 26, 2023 19:57

Typo

cd4a6f3

Remove required ids from DerivedViews

b034777

VehicleJourneyRunTime has a cardinality of 0:1

6a8e19b

skinkie and others added 13 commits July 27, 2023 12:09

Introducing new restrictions, and TODO's

4cf88c0

Better, but still failing

8066af4

More improvements, including required order properties

d6e3660

test for change of one of the TODO

20e6fd6

something went massively wrong...

Update netex_ifopt_site_version.xsd

2b466ef

Update netex_ifopt_site_version.xsd

f7997ad

Revert "Update netex_ifopt_site_version.xsd"

2301590

This reverts commit f7997ad.

Revert "Update netex_ifopt_site_version.xsd"

68338ca

This reverts commit 2b466ef.

Revert "test for change of one of the TODO"

a72adc6

This reverts commit 20e6fd6.

Fix id on InterchangeRuleTiming on VDV452 example.

4fe6625

Update FlexibleServiceProperties in NOPTIS example.

8abed5f

Fix DestinationDisplayVariant example

7db58d3

Introduce VehicleTypeZoneRestriction id and version attributes

9b167f1

ue71603 reviewed Jul 28, 2023

View reviewed changes

ue71603 added 2 commits July 28, 2023 12:57

Entrance, VehicleEntrance change

bb90df4

Merge branch 'fix_attribute_id_use_required' of https://github.com/Ne…

b0cfdbd

…TEx-CEN/NeTEx into fix_attribute_id_use_required

skinkie commented Jul 28, 2023

View reviewed changes

ue71603 and others added 2 commits July 28, 2023 15:28

adding Entrance_

198c470

Fix TopographicProjection required id and version

0097ce5

skinkie and others added 9 commits July 28, 2023 15:48

Add required order attribute to FareTableRow

2fd8ceb

Make sure FareTableColumn has a required order element

7a99a15

Introduce version and id attributes for AlternativeNameMake sure Fare…

6789446

…TableColumn has a required order element

SubstitionGroup Entrance_ fixed substitutionGroup TyoeOfEntity_ fixed

02e93ca

Fixing Point_

30dd071

Fixing Zone_ substitutionGroup

bcfe427

removed ambiguity from GeneralFrameMember

2716f67

corrected SignEquipment substitutionGroup

86c7891

fixed substitutionGroup CustomerService for better id

c3ec847

ue71603 and others added 4 commits July 29, 2023 18:36

fixing AccessRightInProduct substitutionGroup

d624884

Fixing Entrance problem. Typo changed

9c6737e

changing refs to xxx_ elements

0886b7a

Lint and update documentation tables

a84cde5

skinkie commented Aug 3, 2023

View reviewed changes

skinkie mentioned this pull request Oct 3, 2023

PassengerCapacity@id #515

Closed

Aurige mentioned this pull request Oct 17, 2023

Conflicting example for Version elements #208

Closed

ue71603 added the group_decision_needed label Nov 21, 2023

ue71603 added this to the netex_1.2 milestone Dec 1, 2023

ue71603 added late_work and removed group_decision_needed labels Dec 14, 2023

ue71603 modified the milestones: netex_1.2, netex_2.0 May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Required IdType fixes #471

Required IdType fixes #471

skinkie commented Jul 26, 2023 •

edited

skinkie commented Jul 26, 2023

ue71603 Jul 28, 2023

skinkie Jul 28, 2023

skinkie Jul 28, 2023

ue71603 Jul 28, 2023

ue71603 Jul 28, 2023

ue71603 Jul 28, 2023

skinkie Jul 28, 2023

ue71603 commented Jul 29, 2023

skinkie Aug 3, 2023

ue71603 Aug 3, 2023

skinkie Aug 3, 2023

Aurige Sep 6, 2023

Aurige commented Sep 6, 2023

Required IdType fixes #471

Are you sure you want to change the base?

Required IdType fixes #471

Conversation

skinkie commented Jul 26, 2023 • edited

skinkie commented Jul 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ue71603 commented Jul 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aurige commented Sep 6, 2023

skinkie commented Jul 26, 2023 •

edited