Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should PassengerCarryingRequirementsView be a DataManagedObjectView/DerivedView? #474

Open
skinkie opened this issue Jul 27, 2023 · 6 comments
Assignees
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Milestone

Comments

@skinkie
Copy link
Contributor

skinkie commented Jul 27, 2023

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd#L668

@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Jul 27, 2023
@skinkie skinkie changed the title Should PassengerCarryingRequirementsView be a DerivedView? Should PassengerCarryingRequirementsView be a DataManagedObjectView/DerivedView? Jul 27, 2023
@ue71603
Copy link
Contributor

ue71603 commented Jul 29, 2023

I think it would be good to have a cleaner hierarchy here.

@Aurige
Copy link
Contributor

Aurige commented Sep 7, 2023

To me, PassengerCarryingRequirementsView should have substitutionGroup="DerivedView"
(the PassengerCarryingPassengerCarrying_ViewStructure has DerivedViewStructure as a base)

@ue71603 ue71603 added this to the netex_2.0 milestone Dec 1, 2023
@ue71603
Copy link
Contributor

ue71603 commented Dec 12, 2023

@Aurige can you do this one?

@nick-knowles
Copy link
Contributor

I'm agnostic on this - perhaps calling a view a view is sufficient to identify it as a view, or should we formally make views substitutable subtypes of derived views? since views are all fof different things they dont really have common aspects other than a reference to the persistent element over which they provide a view

Another issue is concerns the ids of views. Doviews (a) always have an id?(b) is the id codespace the view's own unique id codespace , or is it the same as that of the source of a derived element ? (d) do we specify a constraint to enforce uniqueness?

It is probably useful to allow an id, so implentors who have actually implemented persistent entities corresponding to the view (e,g, CALLs ) , can make a round trip exchange.

@skinkie
Copy link
Contributor Author

skinkie commented Dec 20, 2023

I'm agnostic on this - perhaps calling a view a view is sufficient to identify it as a view, or should we formally make views substitutable subtypes of derived views? since views are all fof different things they dont really have common aspects other than a reference to the persistent element over which they provide a view

If you would be willing to support such change, I would be happy to help. It would make things more clear once parsing them.

@ue71603
Copy link
Contributor

ue71603 commented Feb 2, 2024

@skinkie Can you formulate the PR then?

@ue71603 ue71603 assigned skinkie and unassigned Aurige Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Development

No branches or pull requests

5 participants