Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicted occupation #605

Open
wants to merge 18 commits into
base: next
Choose a base branch
from
Open

Predicted occupation #605

wants to merge 18 commits into from

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Dec 13, 2023

solves #398

However, currently only works for Calls

@Aurige I need guidance: How to put this into PassingTime /VDV 462 method. And also do we need for new mode a version that puts it on the Vehicle? Somewhere else?

Also folders: Should the thing be in a different folder? Should other NeTEx specific elements be incorporated?
Did I get the right "entrance" into formation?

@ue71603 ue71603 added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated labels Dec 13, 2023
@ue71603 ue71603 added this to the netex_2.0 milestone Dec 13, 2023
@ue71603 ue71603 mentioned this pull request Dec 13, 2023
@skinkie
Copy link
Contributor

skinkie commented Dec 13, 2023

Question: is there a reason you want to use a NeTEx element, instead of reuse a SIRI element?

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 14, 2023

Question: is there a reason you want to use a NeTEx element, instead of reuse a SIRI element?

@Aurige Do you want this methodically?

@Aurige
Copy link
Contributor

Aurige commented Dec 14, 2023

Thanks @ue71603 ... it's a very goo starting point. We need to make a few updates for a better NeTEx integration, I will work on it ASAP (jumping from meeting to meeting right now :-( )

Addition of the 2 files in the XMLSpy project
@ue71603
Copy link
Contributor Author

ue71603 commented Dec 14, 2023

Nick: CheckConstraint in NeTEx. Enum in NeTEx. reconsiliation. needed with simple NeTEx.
Christophe: Is at calls is natural. Occupany varies from day to day. It is different.
Nick: Journey and JourneyPart and Deck/Level needed and per date. PointInJourneyPattern would be better.
Christophe: DayType structure needed.
DayType added to VehicleOccupancy.
Like RunTime/WaitTime.
Into part Deck Plan element. right deck plan.

part2_oc_

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 14, 2023

not import SIRI.

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 18, 2023

  • switched to part 2
  • DayType added
  • occupancies now also as part of TimetableFrameGroup
  • occupancies added to JourneyGroup and JourneyPartGroup
  • made Occupancy a first class citizen
  • rebuild everything to occupancies
  • updates example

ue71603 and others added 3 commits December 18, 2023 19:36
switched to part 2
DayType added
occupancies now also as part of TimetableFrameGroup
occupancies added to JourneyGroup and JourneyPartGroup
made Occupancy a first class citizen
rebuild everything to occupancies
updates example
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have an example for "a call or a timetabled passing time"? Would it also be possible to have OccuptationInFrame which references a ServiceJourney.

ue71603 and others added 2 commits December 22, 2023 14:25
- PassingTime right
- additional PassingTime example
- fixed documentation of values
- fixed example
Copy link
Contributor

@Aurige Aurige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solving some Occupancy_RelStructure and OccupancyInFrame_RelStructure (in FRAME cannot contain Refs)

ue71603 and others added 6 commits March 14, 2024 18:16
Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
…on.xsd

Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
….xsd

Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
Copy link
Contributor

@Aurige Aurige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did it too quickly, the sequence was missing

Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
@ue71603 ue71603 assigned ue71603 and unassigned Aurige Apr 10, 2024
@nick-knowles
Copy link
Contributor

FYI This is the Transmodel model for recording historic occupancy.
image

@nick-knowles
Copy link
Contributor

nick-knowles commented Apr 15, 2024

THe current proposal has several issues
a) The occupancy counts by each type are denormalised so that different categories occupancy are flattened out and explicitly enumerated , ok but less flexible / extensible than having a subelement with type of occupancy/ occupancy count subelement
b) seems to be conflating concerns (historic reporting of all occupancies for all day types vs prediction fo a specific journey)
(c) redundant and potentially conflicting by having filter values that can be in conflict with parent context by mixing in day types and other stuff that is already given by the parent context

Would be cleaner as a simple occupancy content structure (ie no filters etc) that goes on specific context eg a a call . journey part etc that already have a daytype etc (b) a standalone n occupancy container with filters etc that allows the same occupancy content to be exchanged by itself - and is closer to the UML for NetEx transmodel. Also them which Frame would the cccupancy container go in?
image

@Aurige
Copy link
Contributor

Aurige commented Apr 16, 2024

@nick-knowles - @ue71603 - @Aurige to Update the proposal, including Transmodel update (maybe for next TM revision)

@ue71603
Copy link
Contributor Author

ue71603 commented Apr 17, 2024

@nick-knowles
Copy link
Contributor

Ulf has proposed revisions to the TM Vehicle Occupancy MODEL to separate estimated from actual values
image

Also some renaming of elements for SPOT OCCUPANCY
image

@ue71603
Copy link
Contributor Author

ue71603 commented Jun 21, 2024

I think @Ulf9 @Aurige @nick-knowles you will have to do the PR changes. The new TM conform NeTEx structure is way to complex as for SBB to ever consider implementing it for Switzerland in the foreseeable future as we already have a working version: https://opentransportdata.swiss/de/dataset/occupancy-forecast-siri-dataset
And if it needs to better fit into DECK PLAN, then I am the wrong person to do it anyhow.

@ue71603 ue71603 assigned Aurige and unassigned ue71603 Jun 21, 2024
@Aurige
Copy link
Contributor

Aurige commented Jun 24, 2024

I agree that going to the details of the DECK PLAN level is quite a lot of work, and will lead to a lack of a global overview of the occupancies. Knowing that time is flying, and that there are quite a lot of request for this information, could we stick on this implementation proposed by @ue71603 , maybe rename it "OccupancyView" and accept it (just solve the small issues in the comments) ?
I add it as a discussion point for next meeting

<PassengerCategory>adult</PassengerCategory>
<OccupancyPercentage>60</OccupancyPercentage>
</Occupancy>
<OccupancyRef version="any" ref="occ4"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would this OccupancyRef mean in this context?

@skinkie
Copy link
Contributor

skinkie commented Jun 26, 2024

Discussion:
Think in an OccupancyFrame which an occupancyAssignment (similar noticeAssignment).
OccupancyView might also be 'better'.

@ue71603 ue71603 assigned ue71603 and unassigned Aurige Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants