Enhancement=fare-debit Internal restructuring to enable reuse of payment #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Payment details are modularised onto a separate FARE DEBIT element as per TM . This is a "hygiene" prereq for making further transactions and validation additiosn to enable thr ENTUR customer account CR . Shoudl not functionally
ue71603
reviewed
Dec 21, 2023
ue71603
added
the
enhancement
trurlurl
approved these changes
Jan 1, 2024
ue71603
requested changes
Feb 17, 2024
There was a problem hiding this comment.
The xxxDebit structure is build, but nowhere applied. Also no example is provided.
@nick-knowles update is needed
|
@skinkie should I add an example? and what do we do with the not used structure? |
Ask the creator of this pull request to fix it. |
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_fareDebit_version.xsd
Outdated
Show resolved
Hide resolved
skinkie
reviewed
Jul 25, 2024
| <xsd:annotation> | ||
| <xsd:documentation>Elements for OTHER DEBIT</xsd:documentation> | ||
| </xsd:annotation> | ||
| <xsd:sequence/> |
There was a problem hiding this comment.
TM: A LOG ENTRY recording data about a debiting action for a payment type other than a FARE PRODUCT SALE DEBIT, TRIP DEBIT, OFFENCE DEBIT or BOOKING DEBIT.
skinkie
reviewed
Jul 25, 2024
| <xsd:annotation> | ||
| <xsd:documentation>Elements for TRIP DEBIT</xsd:documentation> | ||
| </xsd:annotation> | ||
| <xsd:sequence/> |
There was a problem hiding this comment.
from TM: A LOG ENTRY recording data about a debiting action for post-payment for a specific trip.
To be detailed in the doc
skinkie
reviewed
Jul 25, 2024
| <xsd:annotation> | ||
| <xsd:documentation>Elements for BOOKING DEBIT</xsd:documentation> | ||
| </xsd:annotation> | ||
| <xsd:sequence/> |
There was a problem hiding this comment.
From TM : A LOG ENTRY recording data about a debiting action for a booking fee.
To be detailed in the doc
There was a problem hiding this comment.
I am talking about the empty sequence.
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_customerPurchasePackage_version.xsd
Outdated
Show resolved
Hide resolved
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_fareDebit_support.xsd
Outdated
Show resolved
Hide resolved
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_fareDebit_support.xsd
Outdated
Show resolved
Hide resolved
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_fareDebit_support.xsd
Outdated
Show resolved
Hide resolved
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_fareDebit_support.xsd
Outdated
Show resolved
Hide resolved
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_fareDebit_version.xsd
Outdated
Show resolved
Hide resolved
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_fareDebit_version.xsd
Outdated
Show resolved
Hide resolved
skinkie
reviewed
Jul 25, 2024
xsd/netex_part_3/part3_salesTransactions/netex_salesContract_version.xsd
Outdated
Show resolved
Hide resolved
|
in my opinion, this should go to next |
…on.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…ePackage_version.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…rt.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…rt.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…rt.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…rt.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…on.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…on.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…ersion.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
skinkie
approved these changes
Jul 25, 2024
ue71603
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment details are modularised onto a separate FARE DEBIT element as per TM model (Previously they were included in the SALES TRANSACTION package) . This is a small "hygiene" internal restructure prereq for making further transactions and validation additions to enable the ENTUR customer account CR . Should not functionally change anything. At some point a further change could be introduced to SALES TRANSACTION wrap payment details in a debit tag