Adding support for Calendar events #310
Conversation
|
Just to clarify, there are two major open points:
Apart from that, it is working fine. I have watched the discussions about searching in apps. Is it for calendar events too? |
Conflicts: app/src/main/java/fr/neamar/kiss/DataHandler.java app/src/main/java/fr/neamar/kiss/result/Result.java
| event.displayName = event.name.replaceFirst( | ||
| "(?i)(" + Pattern.quote(query) + ")", "{$1}"); | ||
|
|
||
| //event.setDisplayNameHighlightRegion(matchPositionStart, matchPositionEnd); |
|
Also, it's my opinion, but if it can't detect new events / changes, I'm afraid the use is somewhat limited, and can lead to unexpected behaviour from users not aware of that... Also, there is some work to do about the icon. Is it possible to get the default calendar app icon? (I assume the event is opened in this app, so that would make sense) |
|
Hi saveman71, thank you for the comments!
|
|
Could maybe someone comment on the current state? I use the system icon now. Special search queries:
edit: To monitor changes, I listen to modifications on the data. If someone is not using the stock calendar app but lets say only the google calendar (i don't know if this is technically possible), then no events will be shown. |
|
Hey @nmitsou , Sorry for the delay. I know, I'm lagging >< I saw this PR a few days ago, and although I did not test it yet, I'm still asking myself. It looks impressive, and yet I find myself asking whether or not this is a feature I want, or if it would just pollute my search history. Now, this could be an option disabled by default too, in which case I probably won't have any bad feeling about it! I'll put this on my device on run with it for a few days, to see how this goes. And once again, sorry for the lack of reply. |
|
(edit. Used it for a few second and already love the !week. I'm a heavy Calendar user though... and i'll have to wait a few days to see if it's more convenient than using the actual agenda) |
|
Hi, since you are testing, I made a modification on the icon to make it useful (but not ready to push yet). I attach a screenshot. If the user has selected no-app-icon mode, then the old icon is shown |
|
if you agree, i will add a switch on settings to enable/disable the appearance of events on search. edit: i wouldnt see this as a replacement of calendar but as a quick view of events complimentary to calendar. to be more useful i would like to pin the !week itself on the kissbar or add it on the history |
…ries. The descriptions / titles might need tuning
|
I added the additional option to include or not events on search (the description string might need some work) and uploaded the icon improvement. |
|
I don't know why the checks are failing. Locally everything is working fine. |
Events on calendar are added to search. At the moment, events at the next 30 days are only loaded.
The user can disable it on settings.
android.permission.READ_CALENDAR is added.
If you type "events: " all events are shown
I don't know if you find this useful and want to merge at some point.
I like it and use it already since I am missing a calendar widget.
Any comments are welcome.