Release v0.1.5 #291
Merged
Release v0.1.5 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add channel semaphores to serialize the startup of the NLC reconcilers that are using EC. Add locks to each reconciler to block its Reconcile() until it has completed its Start(). Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
The NnfStorageProfile/placeholder resource is meant to be an example resource and should not be marked as default. Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Add a dummy channel semaphore to satisfy the reconciler's Start() so it can release the Reconcile() method. These semaphores are being used by the nnf-node-manager controller and aren't needed here in the clientmountd. Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
- Moved `getRabbitRelativePath` to its own function for testability - `getRabbitRelativePath` now preserves trailing slashes for the path - Fixed issue with `splitStagingArgumentIntoNameAndPath` assuming a leading slash - Added unit tests for `splitStagingArgumentIntoNameAndPath` and `getRabbitRelativePath` Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
The k8s-go community broke a few things this morning, our time. Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
#286) Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
This ensures that any existing pools are imported and present after a reboot of the rabbit node. Tested by: 1. Create lustre workflow and transition to PostRun 2. Reboot the rabbit-node prior to Teardown 3. Once rebooted, verify that zool list includes pools 4. Verify log contains "Imported all available zpools" 1. Do #1 from above. 2. Transition to Teardown and then very quickly reboot the rabbit node (`ssh rabbit-node-2 reboot`). 3. Once rabbit node reboots, workflow will transition to Teardown complete. 4. Verify #4 above. 5. Verify `zpool list` as no pools left. Signed-off-by: Blake Devcich <blake.devcich@hpe.com> moved import to NnfNodeECData.Start() Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
- Wait for VG to show up in the OS before trying to lock it Signed-off-by: Anthony Floeder <anthony.floeder@hpe.com>
Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
- vgs/lvs commands avoid locking
Signed-off-by: Anthony Floeder <anthony.floeder@hpe.com>
roehrich-hpe
approved these changes
Apr 3, 2024
bdevcich
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.