Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serial: change serial number check #630

Merged
merged 1 commit into from
Jun 29, 2023
Merged

serial: change serial number check #630

merged 1 commit into from
Jun 29, 2023

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Jun 28, 2023 •
edited
Loading

  • use /proc/device-tree/serial-number unless not available
  • fall back to /proc/cpuinfo
  • fixes serial number mismatch problem on bobcat

Issue

  • Link:
  • Summary:

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@shawaj shawaj marked this pull request as ready for review June 29, 2023 00:25
@shawaj shawaj requested review from a team as code owners June 29, 2023 00:25
@shawaj
serial: change serial number check
c4aa8af 
- use /proc/device-tree/serial-number unless not available
- fall back to /proc/cpuinfo
- add unit tests
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj shawaj merged commit 8ca36df into master Jun 29, 2023
17 checks passed
@shawaj shawaj deleted the shawaj/serial branch June 29, 2023 00:58
shawaj added a commit to NebraLtd/helium-miner-software that referenced this pull request Jun 29, 2023
@shawaj
Bobcat and RockPi serial fix
06bc552 
Bump diagnostics to bring in serial fix

NebraLtd/hm-diag#632
NebraLtd/hm-diag#630
@shawaj shawaj mentioned this pull request Jun 29, 2023
Merged
4 tasks
shawaj added a commit that referenced this pull request Jun 30, 2023
@shawaj
serial: check for known incorrect rockpi serials
eeb3f95 
- check for known incorrect rockpi serials
- add more tests for serial number determination

Relates-to: #507 
Relates-to: #632 
Relates-to: #630
@shawaj shawaj mentioned this pull request Jun 30, 2023
Merged
4 tasks
shawaj added a commit that referenced this pull request Jul 2, 2023
@shawaj
serial: check for known incorrect rockpi and bobcat serials
758d971 
- check for known incorrect rockpi serials
- check for known incorrect bobcat serials
- check for missing or too-short serials
- add more tests for serial number determination

Relates-to: #507
Relates-to: #632
Relates-to: #630
shawaj added a commit that referenced this pull request Jul 2, 2023
@shawaj
serial: check for known incorrect rockpi and bobcat serials
081ecda 
- check for known incorrect rockpi serials (and similar 10 char non hex serials)
- check for known incorrect bobcat serials
- check for missing or too-short serials
- add more tests for serial number determination
- bump hm-pyhelper

Relates-to: #507
Relates-to: #632
Relates-to: #630
shawaj added a commit that referenced this pull request Jul 2, 2023
@shawaj
serial: check for known incorrect rockpi and bobcat serials
1553081 
- check for known incorrect rockpi serials (and similar 10 char non hex serials)
- check for known incorrect bobcat serials
- check for missing or too-short serials
- add more tests for serial number determination
- bump hm-pyhelper

Relates-to: #507
Relates-to: #632
Relates-to: #630
shawaj added a commit that referenced this pull request Jul 2, 2023
@shawaj
serial: check for known incorrect rockpi and bobcat serials
424d9bf 
- check for known incorrect rockpi serials (and similar 10 char non hex serials)
- check for known incorrect bobcat serials
- check for missing or too-short serials
- add more tests for serial number determination
- bump hm-pyhelper

Relates-to: #507
Relates-to: #632
Relates-to: #630
shawaj added a commit that referenced this pull request Jul 2, 2023
@shawaj
serial: check for known incorrect rockpi and bobcat serials
c3960c1 
- check for known incorrect rockpi serials (and similar 10 char non hex serials)
- check for known incorrect bobcat serials
- check for missing or too-short serials
- add more tests for serial number determination
- bump hm-pyhelper

Relates-to: #507
Relates-to: #632
Relates-to: #630
shawaj added a commit that referenced this pull request Jul 2, 2023
@shawaj
serial: check for known incorrect rockpi and bobcat serials
3626fb5 
- check for known incorrect rockpi serials (and similar 10 char non hex serials)
- check for known incorrect bobcat serials
- check for missing or too-short serials
- add more tests for serial number determination
- bump hm-pyhelper

Relates-to: #507
Relates-to: #632
Relates-to: #630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shawaj