Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serial: check for known incorrect rockpi and bobcat serials #633

Merged
merged 1 commit into from
Jul 2, 2023
Merged

serial: check for known incorrect rockpi and bobcat serials #633

merged 1 commit into from
Jul 2, 2023

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Jun 30, 2023 •
edited
Loading

  • check for known incorrect rockpi serials (and similar 10 char non hex serials)
  • check for known incorrect bobcat serials
  • check for missing or too-short serials
  • add more tests for serial number determination
  • bump hm-pyhelper

Relates-to: #507
Relates-to: #632
Relates-to: #630

Issue

  • Link:
  • Summary:

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@shawaj shawaj mentioned this pull request Jul 2, 2023
Open
@shawaj shawaj changed the title serial: check for known incorrect rockpi serials serial: check for known incorrect rockpi and bobcat serials Jul 2, 2023
@shawaj shawaj marked this pull request as ready for review July 2, 2023 02:56
@shawaj shawaj requested review from a team as code owners July 2, 2023 02:56
@shawaj shawaj force-pushed the shawaj/serialrockpi branch 4 times, most recently from 2b1b8ec to c3960c1 Compare July 2, 2023 14:54
@shawaj
serial: check for known incorrect rockpi and bobcat serials
3626fb5 
- check for known incorrect rockpi serials (and similar 10 char non hex serials)
- check for known incorrect bobcat serials
- check for missing or too-short serials
- add more tests for serial number determination
- bump hm-pyhelper

Relates-to: #507
Relates-to: #632
Relates-to: #630
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj shawaj merged commit 10c664a into master Jul 2, 2023
@shawaj shawaj deleted the shawaj/serialrockpi branch July 2, 2023 15:34
shawaj added a commit to NebraLtd/helium-miner-software that referenced this pull request Jul 2, 2023
@shawaj
Bump diag
df05546 
Ref NebraLtd/hm-diag#633
@shawaj shawaj mentioned this pull request Jul 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shawaj