-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lobby system for new joining players #488
Conversation
…es planet size, position and orbit along its inclination.
Compatibility with GS2 is done through Touhma/DSP_Galactic_Scale#146 |
…tails by clicking into space. can view planet details by clicking on them. correct display of birth star.
…n solar system details view. works for host and clients, but still wip.
…lobby correctly, main menu is less distorted after solar system preview
…oes not show vein amount anymore, handle custom birth planet on rerand galaxy, remove unneeded ArrivePlanet call causing issues with gs2
Should be okay now, there are some slight QoL things that could be added but i leave that for later to focus more on the reported bugs. |
if (tcpClient != null) | ||
{ | ||
tcpClient.NoDelay = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this done for a particular reason? Is tcpClient null when opening the connection for the lobby? i think it shouldn't be hm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it was for a particular reason i dont remember it anymore :)
…he multiplayer galaxy select screen gets opened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, works great! Great work! :D
Nice work ! |
This adds a lobby to the game. When starting a new game players can join into the galaxy selection screen now. Joining players will land in that screen too if:
The join normally into the game if they already played as clients on that savegame.
What i plan to add:
This will be especially usefull regarding the combat system that the game devs want to add since this could be the base for a player vs player scenario.
Here is a short demo how it looks atm.
Joining the lobby on a new game
Joining the lobby on a running game
Joining the game after you already did as client