Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lobby system for new joining players #488

Merged
merged 13 commits into from
Jan 1, 2022

Conversation

sp00ktober
Copy link
Collaborator

This adds a lobby to the game. When starting a new game players can join into the galaxy selection screen now. Joining players will land in that screen too if:

  • Host is still in galaxy selection
  • Player joins the first time on that savegame

The join normally into the game if they already played as clients on that savegame.

What i plan to add:

  • players can choose their starting planet in the galaxy selection screen.
  • players can see planet details when clicking on a planet in galaxy selection screen

This will be especially usefull regarding the combat system that the game devs want to add since this could be the base for a player vs player scenario.

Here is a short demo how it looks atm.

Joining the lobby on a new game
Joining the lobby on a running game
Joining the game after you already did as client

@sp00ktober sp00ktober added the enhancement New feature or request label Dec 13, 2021
…es planet size, position and orbit along its inclination.
@sp00ktober
Copy link
Collaborator Author

grafik
Solar system details can now be visualized, but there are still some things i need to implement here.

Also this is currently not compatible with GS2 as it prefixes methods in UIVirtualStarmap blocking the patches i added.

@sp00ktober
Copy link
Collaborator Author

Compatibility with GS2 is done through Touhma/DSP_Galactic_Scale#146

…tails by clicking into space. can view planet details by clicking on them. correct display of birth star.
@sp00ktober
Copy link
Collaborator Author

grafik
Last commit added the possibility to view planet details (vein amount not accurate with GS2 yet) as well as moving "back" in detail level by clicking into space.

…n solar system details view. works for host and clients, but still wip.
…lobby correctly, main menu is less distorted after solar system preview
…oes not show vein amount anymore, handle custom birth planet on rerand galaxy, remove unneeded ArrivePlanet call causing issues with gs2
@sp00ktober
Copy link
Collaborator Author

Should be okay now, there are some slight QoL things that could be added but i leave that for later to focus more on the reported bugs.

@sp00ktober sp00ktober marked this pull request as ready for review December 29, 2021 18:39
Comment on lines +255 to +258
if (tcpClient != null)
{
tcpClient.NoDelay = true;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this done for a particular reason? Is tcpClient null when opening the connection for the lobby? i think it shouldn't be hm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was for a particular reason i dont remember it anymore :)

sp00ktober and others added 2 commits January 1, 2022 12:58
…he multiplayer galaxy select screen gets opened.
it should either be "into space" or "into outer space", I think the latter is slightly clearer
Copy link
Collaborator

@PhantomGamers PhantomGamers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, works great! Great work! :D

@hubastard
Copy link
Collaborator

Nice work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants