Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes several Shaded Hills map issues #4198

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Fixes several Shaded Hills map issues #4198

merged 6 commits into from
Jul 16, 2024

Conversation

MistakeNot4892
Copy link
Contributor

Fixes several issues from #4191.

  • Renames several daycycle vars/types to be clearer.
  • Increases length of default daycycle to an hour, and shaded hills to 2 hours. The effective daylight period is less than half the total, so it was very short on Shadyhills.
  • Uncommented weather transition weighting and tweaked the weightings.
  • Allowed weather to be supplied a list of states to forbid, and forbids snow on Shaded Hills.
  • Moves Shaded Hills weather into a new finalize_map_generation() proc on /datum/map, called at the end of SSmapping Initialize().
  • Adds GLUT_TINY to drakes so they can eat mice. This is important apparently.

@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label Jul 13, 2024
out-of-phaze
out-of-phaze approved these changes Jul 13, 2024
View reviewed changes
code/modules/weather/weather_fsm.dm
@@ -6,5 +6,5 @@
for(var/decl/state_transition/weather/state_transition in valid_transitions)
transitions[state_transition] = state_transition.likelihood_weighting
if(length(transitions))
return pick(transitions) //pickweight(transitions)
return pickweight(transitions)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHAT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had no clue the transition weighting was disabled...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought pickweight was broken.

@out-of-phaze out-of-phaze merged commit 28e2947 into NebulaSS13:dev Jul 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@out-of-phaze out-of-phaze out-of-phaze approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MistakeNot4892 @out-of-phaze