RPC errors #184
RPC errors #184
Conversation
| if prevHeight != c.Height() { | ||
| go c.CatchUp(c.RandomPeer()) | ||
| if err == moreBlocksErr { | ||
| go c.CatchUp(peer) | ||
| } |
There was a problem hiding this comment.
I'm reusing the old peer here, but that might not be best practice. On one hand, if a peer tells you it has more blocks, you probably want to ask that specific peer again. On the other hand, this allows a malicious host to trap you in an infinite CatchUp loop by always returning moreBlocksErr.
There was a problem hiding this comment.
this is avoidable by checking yourself to see that the host has actually supplied more blocks.
|
Can you add more documentation? Specifically a file somewhere that explains the general philosophies and approaches behind the network package? |
|
I'll probably make an issue about it. |
|
sure. I'm thinking the package should be renamed anyway (sianet?), so I'll lump those two changes together. |
RPCs now send and receive errors. Registered functions like
SendBlocksthat return an error will write that error to the connection. If it's anet.Connfunction likeRetrieveFile, you have to write the error manually. All existing RPCs have been updated to make use of errors. However, there still isn't much logic for processing specific RPC errors, except inCatchUp, which now looks for a specific "more blocks are available" error.