Skip to content
This repository has been archived by the owner on Jul 30, 2020. It is now read-only.

Updates TinyIoC.cs #1669

Merged
merged 1 commit into from
May 7, 2017
Merged

Updates TinyIoC.cs #1669

merged 1 commit into from
May 7, 2017

Conversation

CDAGaming
Copy link
Contributor

This PR Realigns TinyIoC.cs to Master and Includes several Bug-Fix PR Changes:

Included PRs:
grumpydev/TinyIoC#114
grumpydev/TinyIoC#111
grumpydev/TinyIoC#110
grumpydev/TinyIoC#105

@Lord-Haji
Copy link
Member

@CDAGaming why r u merging unmerged PRs, if they get rejected we shall have trouble too

@CDAGaming
Copy link
Contributor Author

@Lord-Haji These PRs were common changes in the other Prs. They were bug-fixes for TinyIoC that the origin dev hadn't merged, maybe because of lack of time or dropping of project. If you read what the PRs do, they do not seem to have any controversy as other prs on there have had

@Lord-Haji Lord-Haji merged commit 365b9ef into Necrobot-Private:master May 7, 2017
@jjskuld
Copy link
Contributor

jjskuld commented May 7, 2017

Makes me wonder if we should be using a better IoC solution, one that is supported.

Take a look at http://www.palmmedia.de/blog/2011/8/30/ioc-container-benchmark-performance-comparison

@jjskuld
Copy link
Contributor

jjskuld commented May 7, 2017

Based on the above link, DryIoc looks pretty good and is constantly being updated.

https://www.nuget.org/packages/DryIoc/

Just updated a few days ago.

@CDAGaming
Copy link
Contributor Author

@jjskuld Hm, looks good, May test this out in a bit :)

Would be better than TinyIoC, as it seems origin dev is MIA is seems

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants