This repository has been archived by the owner on Jul 30, 2020. It is now read-only.
Fix #179 WildPokemon-error with Incense/Lures #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Ugly/untidy version)
|
Hm. The changes to MSnipeService aren't solid. Have to verify the response type there as well. |
|
Should work as this as long as MSnipe never runs into any other responses than Wildpokemon |
|
Maybe you can talk it to @msx752, so it will no conflict at the server... |
|
My fault. İ am on way, now i cant Access to computer . , nearly 3 hours later i will create pr wait me for next release. Thanks |
|
Went through that part again and I don't think it should intervene with msx's code. It appears MSnipe only accepts EncounterResponse to begin with so it was never an issue. |
ghost
added
the
Lord-Haji
pushed a commit
to Lord-Haji/NecroBot-1
that referenced
this pull request
Apr 26, 2017
Remove GeoCoordinate.NetStandard1, which is no longer used.
Furtif
pushed a commit
to Furtif/NecroBot
that referenced
this pull request
May 20, 2017
Added proper language system
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problems with WildPokemon etc not working with Incense/Lures.
Ugly/untidy version. In a hurry so will have to clean up the code later. Seemingly works though. Second opinion welcome!