Fix Rails 4.2 AREL bug. Bind values manually #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its backwards compatible with Rails 3.0+ |
Nedomas
added a commit
that referenced
this pull request
Apr 10, 2015
Fix Rails 4.2 AREL bug. Bind values manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2
AdequateRecordof Rails 4.2 changed the way AREL binds values to the query object.This is the simplest solution I've come up with.
@remigijusj solution (https://gist.github.com/remigijusj/65ce558215292b85948b) is better as it uses
bind_valuesmechanism, but introduces a strange dynamic of binding values onwherequery and not on a standalone query object.@remigijusj, what do you think?
Rspecs pass.