Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add faq and troubleshooting entry regarding insecure response #333

Merged
merged 6 commits into from
Feb 13, 2019

Conversation

GGAlanSmithee
Copy link
Collaborator

Regarding #296

Not sure if I interpreted the issues corectly. Added to both FAQ and troubleshooting, since it's not really clear where it should be. Let me know if you want anything changed @NekR

@NekR
Copy link
Owner

NekR commented Dec 27, 2017

Hey! I believe I meant only troubleshooting part, but I'm totally fine with having relativePaths explanation in FAQ 👍

About troubleshooting section. I think we need to say something about that serviceworker/appcache files might be generated into a wrong directly. I know it's partially implied by "see FAQ about relativePaths" but would be good to make it clearer. E.g. "also make sure that ServiceWorker and/or AppCache files are generated into a right folder. You may use ServiceWorker.output and AppCache.output to change output of the files. See options for details."

Also can you rename serviceworker.js to sw.js since sw.js is the default naming. Just to not confuse people.

@GGAlanSmithee Great work as always! Your help is very appreciated. Thanks! 👌 👏

@NekR
Copy link
Owner

NekR commented Dec 27, 2017

Oh, also, any idea why tests are failing with this simple docs PR? Looks like AppVeyor issue/glitch.

@GGAlanSmithee
Copy link
Collaborator Author

@NekR thanks for the excellent feedback I will fix it tomorrow if I find time :) also, I will try to make more contributions 👍

@NekR
Copy link
Owner

NekR commented Dec 28, 2017

Added you to 4.9.0 release notes: https://github.com/NekR/offline-plugin/releases/tag/v4.9.0

Sorry I forgot to do so initially :-(

@GGAlanSmithee
Copy link
Collaborator Author

@NekR fixed your comment - sorry for the delay!

Added you to 4.9.0 release notes: https://github.com/NekR/offline-plugin/releases/tag/v4.9.0

Thanks! Very kind of you. 🙇

@GGAlanSmithee
Copy link
Collaborator Author

Have merged latest master into this. Will merge since you've OK:ed it before @NekR. The problem with the CI will be resolved when #436 is merged, will wait until then.

@GGAlanSmithee GGAlanSmithee merged commit 874beb8 into NekR:master Feb 13, 2019
@GGAlanSmithee GGAlanSmithee deleted the insecure-response-faq branch February 13, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants