fix: notarization team id added #702

NemProject · Jan 13, 2023 · f7be87c · f7be87c
1 parent b1bae6d
commit f7be87c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -88,6 +88,7 @@ npm run release
     export DESKTOP_APP_NOTARIZE=true
     export DESKTOP_APP_APPLE_ID=VALID_APPLE_DEV_ID
     export DESKTOP_APP_APPLE_PASSWORD=VALID_APPLE_DEV_PASSWORD
+    export DESKTOP_APP_APPLE_TEAM_ID=VALID_APPLE_TEAM_ID
     </pre>
 
     7.4 Enable auto discovery for code signing process to pick up the certificates from the keychain

diff --git a/scripts/notarize.js b/scripts/notarize.js
@@ -3,7 +3,7 @@ const appBundleId = require('../package.json').build.appId;
 
 // You will need to notarize the application if the "Developer ID Certificate" is new
 exports.default = async (context) => {
-  const { electronPlatformName, appOutDir } = context;  
+  const { electronPlatformName, appOutDir } = context;
   if (electronPlatformName !== 'darwin') {
     console.log('Skipping notarization because this is not a macOS build.');
     return;
@@ -13,7 +13,10 @@ exports.default = async (context) => {
   } else if (process.env.DESKTOP_APP_APPLE_ID === undefined || process.env.DESKTOP_APP_APPLE_PASSWORD === undefined) {
     console.log('Skipping notarization because DESKTOP_APP_APPLE_ID or DESKTOP_APP_APPLE_PASSWORD env is not set.');
     return;
-  }
+  } else if (process.env.DESKTOP_APP_APPLE_TEAM_ID === undefined) {
+    console.log('Skipping notarization because DESKTOP_APP_APPLE_TEAM_ID env is not set.');
+    return;
+}
   const appName = context.packager.appInfo.productFilename;
   const appPath = `${appOutDir}/${appName}.app`;
 
@@ -24,5 +27,6 @@ exports.default = async (context) => {
     appPath: appPath,
     appleId: process.env.DESKTOP_APP_APPLE_ID,
     appleIdPassword: process.env.DESKTOP_APP_APPLE_PASSWORD,
+    ascProvider: process.env.DESKTOP_APP_APPLE_TEAM_ID,
   });
 };