Export mutating functions from Groups interface #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/groupsstuff
branch
from
aef48c1
to
4c785fc
Compare
thofma
approved these changes
Jan 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
=======================================
Coverage 87.15% 87.15%
=======================================
Files 115 115
Lines 29550 29550
=======================================
Hits 25755 25755
Misses 3795 3795 ☔ View full report in Codecov by Sentry. |
ooinaruhugh
pushed a commit
to ooinaruhugh/AbstractAlgebra.jl
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These function used to be there in GroupsCore, ignored from AA to Hecke, and Oscar implemented them for GAPGroups and exported. #1528 moved the implementation from GroupsCore to AA.
When I removed the silly overloads in Oscar in oscar-system/Oscar.jl#3231 with the intent to use the fallback in AA, the Oscar Aqua tests complain about functions not being there. Since many similar functions are already exported I think these should propagate to Oscar as well (where they already have been exported for a long time).