Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new versions of AA, Nemo, Hecke available #3231

Merged
merged 18 commits into from Jan 27, 2024
Merged

Make new versions of AA, Nemo, Hecke available #3231

merged 18 commits into from Jan 27, 2024

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Jan 24, 2024

This PR collects everything that has to be adapted to keep master green.

GroupsCore: includes and thus closes #3139, closes #3070
Padics: includes and thus closes #3196

[skip ci]

@joschmitt
Copy link
Member

Somebody else has to cherry-pick 0c0e8c8 . I don't have "write" rights.

@lgoettgens
Copy link
Member Author

Somebody else has to cherry-pick 0c0e8c8 . I don't have "write" rights.

I do that once I come across this on my list.

@fingolfin
Copy link
Member

Yeah and we'll likely (?) need #3196 and #3139 and probably more...

@lgoettgens lgoettgens force-pushed the lg/bump-deps branch 2 times, most recently from e087df8 to 749e7e4 Compare January 26, 2024 13:33
@lgoettgens lgoettgens marked this pull request as ready for review January 26, 2024 21:23
@lgoettgens
Copy link
Member Author

Local testing against oscar-system/Singular.jl@f5db183 succeeds now. So I think the only thing missing now is a Singular.jl release (and adjustments to everything else contained in there, e.g. oscar-system/Singular.jl#764).

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Merging #3231 (a984dab) into master (4b3ed0e) will increase coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 92.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3231      +/-   ##
==========================================
+ Coverage   81.63%   81.65%   +0.01%     
==========================================
  Files         546      546              
  Lines       73163    73102      -61     
==========================================
- Hits        59730    59691      -39     
+ Misses      13433    13411      -22     
Files Coverage Δ
...perComplexes/src/Morphisms/simplified_complexes.jl 95.49% <100.00%> (ø)
experimental/ExteriorAlgebra/ExteriorAlgebra.jl 100.00% <100.00%> (ø)
experimental/GModule/GaloisCohomology.jl 63.91% <100.00%> (ø)
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
experimental/LinearQuotients/src/cox_rings.jl 89.37% <100.00%> (ø)
...perimental/LinearQuotients/src/linear_quotients.jl 94.73% <100.00%> (ø)
.../MatroidRealizationSpaces/src/realization_space.jl 85.42% <ø> (ø)
experimental/ModStd/ModStdQt.jl 49.55% <100.00%> (ø)
...ntal/QuadFormAndIsom/src/lattices_with_isometry.jl 99.47% <100.00%> (ø)
experimental/Schemes/Auxiliary.jl 94.38% <100.00%> (ø)
... and 28 more

... and 3 files with indirect coverage changes

@thofma thofma merged commit 910cd54 into master Jan 27, 2024
23 of 24 checks passed
@thofma thofma deleted the lg/bump-deps branch January 27, 2024 14:06
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants