Turn FlintIntegerRing/FlintRationalField into fake singleton type #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
=======================================
Coverage 88.07% 88.08%
=======================================
Files 76 76
Lines 28401 28411 +10
=======================================
+ Hits 25015 25026 +11
+ Misses 3386 3385 -1
Continue to review full report at Codecov.
|
|
Do we really need to fake it? The other one only stalled because of singular. I can try adding mutability checks on the parents as well..., and I think it would be good if singular.jl supported immutable parents anyways ... |
|
Oh if we can do "the real thing" then of course that'd be greatly preferable. I just wasn't sure this would be happening! |
|
Closing in favor of #1221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1221 is stalled or may even be a no-go; but I still think that it's potentially confusing that one can have multiple instances of type
FlintIntegerRing/FlintRationalField; I certainly see code not expecting this.So, let's fake it, by restricting the constructors. Also add tests to verify this works.