Big Renaming, Nemo Edition

[aaruni96]

Renaming things in Nemo, for Oscar 1.0, according to this table

[lgoettgens]

the renaming with padics is already prepared in #1621, so you don't need to do double work for these

[aaruni96]

Whoops, I didn't realize.

I am happy to defer to the work in that PR, but I don't know how to "undo" a published commit.

[lgoettgens]

Whoops, I didn't realize.

I am happy to defer to the work in that PR, but I don't know how to "undo" a published commit.

You can revert a commit (without history rewriting) using git revert abcdef1234 where abcdef1234 is the hash of the commit to be reverted

[codecov]

Codecov Report

Attention: 442 lines in your changes are missing coverage. Please review.

Comparison is base (53bc1d2) 84.17% compared to head (03526cd) 84.18%.

Files	Patch %	Lines
src/arb/acb.jl	80.51%	76 Missing ⚠️
src/arb/arb.jl	81.95%	72 Missing ⚠️
src/HeckeMoreStuff.jl	0.00%	71 Missing ⚠️
src/arb/ArbTypes.jl	62.28%	43 Missing ⚠️
src/antic/nf_elem.jl	69.34%	42 Missing ⚠️
src/arb/acb_mat.jl	72.72%	36 Missing ⚠️
src/arb/acb_poly.jl	72.97%	30 Missing ⚠️
src/arb/arb_poly.jl	73.14%	29 Missing ⚠️
src/arb/arb_mat.jl	76.57%	26 Missing ⚠️
src/arb/RealMat.jl	0.00%	4 Missing ⚠️
... and 9 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
+ Coverage   84.17%   84.18%   +0.01%     
==========================================
  Files          93       93              
  Lines       36814    36814              
==========================================
+ Hits        30987    30992       +5     
+ Misses       5827     5822       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joschmitt]

I don't know what the plan is, but if this pull request is finished, then it would be good if we could merge it soon since there is a big potential for merge conflicts.

[lgoettgens]

I don't know what the plan is, but if this pull request is finished, then it would be good if we could merge it soon since there is a big potential for merge conflicts.

This PR is breaking doctests downstream (they currently don't run due to incompatibily), thus should bump the version to 0.41.0 (@aaruni96 can you take care of that?). But this makes it much less convenient to merge and release 0.40.x bug fix versions while trying to get thofma/Hecke.jl#1362 and oscar-system/Oscar.jl#3231 going. I don't say that it's impossible to do, but just an additional amount of work. So, in my opinion, I would let this wait for one or two more days and hope to get Hecke and Oscar as far as possible in that time.

[thofma]

I think we should first try to make everything compatible with 0.40 downstream and not merge more stuff (to avoid conflicts)