Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to 0.43.1 #1686

Merged
merged 1 commit into from
Feb 26, 2024
Merged

chore: bump to 0.43.1 #1686

merged 1 commit into from
Feb 26, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Feb 25, 2024

No description provided.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (4a1abac) to head (195ebe2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1686   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files          94       94           
  Lines       37084    37084           
=======================================
+ Hits        31348    31349    +1     
+ Misses       5736     5735    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma
Copy link
Member Author

thofma commented Feb 25, 2024

@joschmitt something is going wrong in some inverse of a number field morphism, can you have a look?

Edit: Here https://github.com/Nemocas/Nemo.jl/actions/runs/8038714379/job/21954940877?pr=1686#step:7:1003

@joschmitt
Copy link
Contributor

@joschmitt something is going wrong in some inverse of a number field morphism, can you have a look?

Edit: Here https://github.com/Nemocas/Nemo.jl/actions/runs/8038714379/job/21954940877?pr=1686#step:7:1003

Oh, I thought about this, but then I forgot it again. I have to see, probably the type in Hecke needs to be adjusted.

@thofma thofma merged commit 4637b63 into master Feb 26, 2024
15 checks passed
@thofma thofma deleted the th/bump branch February 26, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants