Consolidate some using statements and make them explicit #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So unfortunately breaking. Edit: OK, if we backport the OSCAR fix, it is non-breaking. |
|
Yeah, I would argue this is technically non-breaking, but OSCAR is relying on some internals here. The fix makes it use other internals, but I think this is fine for now, of this type there are many other occurrences. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
- Coverage 84.54% 84.52% -0.02%
==========================================
Files 94 94
Lines 37092 37092
==========================================
- Hits 31359 31352 -7
- Misses 5733 5740 +7 ☔ View full report in Codecov by Sentry. |
|
oscar-system/Oscar.jl#3431 has now been backported. Any objections @thofma ? |
yuyichao
reviewed
Mar 30, 2024
| using Arb_jll: libarb | ||
| using Antic_jll: libantic | ||
| using Calcium_jll: libcalcium | ||
| using FLINT_jll: libflint |
There was a problem hiding this comment.
These explicit imports break the check for the new flint version below.
yuyichao
added a commit
to yuyichao/Nemo.jl
that referenced
this pull request
Apr 15, 2024
thofma
pushed a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found using the great new tool https://github.com/ericphanson/ExplicitImports.jl