Revert "Revert "QQBar: construct from any Integer or Complex value"" #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1725 +/- ##
==========================================
- Coverage 84.90% 84.87% -0.04%
==========================================
Files 95 95
Lines 37290 37286 -4
==========================================
- Hits 31660 31645 -15
- Misses 5630 5641 +11 ☔ View full report in Codecov by Sentry. |
|
Restarted CI. If neither @fingolfin nor @thofma objects to #1722 (comment), we can merge this once CI is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1723, and thus relands #1702.
This won't work until #1722 is resolved.