Option to skip certificate validation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2022 17:41
Also use http.DefaultTransport for most HTTP clients since it has better defaults, plus we can mutate it from the main app. Signed-off-by: Alessandro Gatti <alessandro.gatti@mikamai.com>
Signed-off-by: Alessandro Gatti <alessandro.gatti@mikamai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a flag to skip TLS certificate validation (for running selfhosted github/gitlab with selfsigned certs, for example).
Testing
No test has been added for this since it's mostly a transport/defaults change.
Checklist
main