Client vs server build integrity check + server startup print neo_version info #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullsystem
changed the title
nullsystem
changed the title
|
As a rogue feature request: could we get some kind of "I know what I'm doing, just let me in" magic bit that's automatically toggled if you're trying to join using a debug build, which would completely bypass this? For dev convenience. This could literally just be a leading/trailing '1'/'0' char bit or whatever. You could still perhaps make it print a client side |
* Server now just prints neo_version on startup * Server and client long git hashes are now matched up on startup to check build integrity. If they don't, the client cannot connect unless they have matching git hashes. * Server convar `neo_sv_build_integrity_check` to enable/disable this integrity check feature. Enabled by default. Debug builds integrity check bypass * Debug builds will have their first byte final bit fliped to 1 to indicate it's a debug build * This will indicate to the server that it's a debug build and if the server allows bypass, then it will * Mask out final bit before comparison to allow debug build that matches hash without first byte final bit * fixes NeotokyoRebuild#437 * fixes NeotokyoRebuild#485
nullsystem
force-pushed
the
GH-437_BuildHash
branch
from
d84a9f6
to
303a61a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
neo_sv_build_integrity_checkto enable/disable this integrity check feature. Enabled by default.neo_sv_build_integrity_check_allow_debugto enable/disable integrity checking for debug clients. Disabled by default for release builds, enabled by default for debug builds.neo_sv_build_integrity_check_allow_debugis disabled, a matching git hash between debug client and server can still be matched.Toolchain
Linked Issues
Examples
Client-side example of integrity check fail setting bogus "foobar" to trigger it:
Server side will log this line: