Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix team chooser menu popup when other player in PVS #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix team chooser menu popup when other player in PVS #511

wants to merge 1 commit into from

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jul 14, 2024 •
edited
Loading

Description

  • NOTE: For reviewers, also checked the "related" PRs under "Linked Issues" to make sure they're not affected negatively also
  • C_NEO_Player::Spawn is called not only for the local client's player, but also for other player (bot or actual) when they're in the local client's PVS
  • If it's called, then only update the VGUIs if it's either local player wasn't set (so it's initially just spawned in) or matches the set local player's pointer.

Toolchain

  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

@nullsystem nullsystem requested review from VantoNortim and a team July 14, 2024 22:56
@nullsystem nullsystem added the bug Something isn't working label Jul 14, 2024
@nullsystem
Fix team chooser menu popup when other player in PVS
ff5f57d 
* `C_NEO_Player::Spawn` is called not only for the local client's
  player, but also for other player (bot or actual) when they're in the
  local client's PVS
* If it's called, then only update the VGUIs if it's either local player
  wasn't set (so it's initially just spawned in) or matches the set local
  player's pointer.
* fixes NeotokyoRebuild#510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VantoNortim VantoNortim Awaiting requested review from VantoNortim

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Team chooser menu popping up when other player on PVS
1 participant
@nullsystem