Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow grenade (frag/smoke) prime+throw on sprint + fix secondary hold #464

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Allow grenade (frag/smoke) prime+throw on sprint + fix secondary hold #464

merged 1 commit into from
Jul 13, 2024

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jul 1, 2024 •
edited
Loading

Description

  • Grenade used to be treated like other weapons where it get blocked when sprinting, this just gives an exemption for grenades/throwables to allow prime+throw on sprint.
  • Regarding secondary throw, this is also allowed on sprint also.
  • Secondary throw also fixed to make it hold rather than instant throw
  • Make sure shoot and aim behavior for other weapons isn't affected/kept prevented on sprint

Toolchain

  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

@nullsystem nullsystem requested a review from a team July 1, 2024 22:04
@nullsystem nullsystem marked this pull request as draft July 2, 2024 19:24
@nullsystem nullsystem changed the title Allow grenade (frag/smoke) prime+throw on sprint Allow grenade (frag/smoke) prime+throw on sprint + fix secondary hold Jul 2, 2024
@nullsystem nullsystem marked this pull request as ready for review July 2, 2024 19:32
@nullsystem
Allow grenade prime+throw on sprint + hold secondary fire
ddae89f 
* Can now sprint and start hold grenade primary+secondary
* Secondary no longer instant, can now hold properly
* fixes NeotokyoRebuild#456
@AdamTadeusz
Copy link
Contributor

AdamTadeusz commented Jul 6, 2024 •
edited
Loading

Noticed a bug on master while testing this branch, supa7 can be shot while sprinting, unlike in the original

(Edit) To clarify for anyone reviewing this PR, the bug mentioned is on master, not on this branch.

@AdamTadeusz AdamTadeusz requested a review from a team July 6, 2024 11:22
@nullsystem nullsystem merged commit 11089d3 into NeotokyoRebuild:master Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VantoNortim VantoNortim VantoNortim approved these changes

@AdamTadeusz AdamTadeusz AdamTadeusz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You should be able to throw grenades while sprinting
3 participants
@nullsystem @AdamTadeusz @VantoNortim