Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Supa7 firerate and right-side icon showing (Supa7 + AA13) #481

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jul 5, 2024

Description

  • Supa7 OGNT firerate is 0.8 (measured using host_timescale 0.1, 8s), not 0.875 which the script stated before
  • Fix not using script's firerate
  • Fix right-side CS-style icons showing up by just setting it like other weapons (this includes AA13)

Toolchain

  • Windows MSVC VS2022

Linked Issues

* Supa7 OGNT firerate is 0.8 (measured using host_timescale 0.1, 8s), not 0.875
* Fix not using script's firerate
* fixes NeotokyoRebuild#422
* Just make them same as the other scripts
@nullsystem nullsystem changed the title Supa7 - Fix firerate Supa7 - Fix firerate and right-side icon showing Jul 5, 2024
@nullsystem nullsystem requested a review from a team July 5, 2024 20:03
@nullsystem nullsystem changed the title Supa7 - Fix firerate and right-side icon showing Fix Supa7 firerate and right-side icon showing (Supa7 + AA13) Jul 5, 2024
@AdamTadeusz
Copy link
Contributor

image
The fire-rate on master is indeed too quick, the value of 0.8 seems correct compared to the 0.875 defined in the script file. Maybe in the original they use the duration of the animation but with a different multiplier than 0.75? Because 0.875 is what is in the most recent one of Agiel's weapon script decompilations in the architects channel

@nullsystem
Copy link
Collaborator Author

@AdamTadeusz That's kind of my guess also, when setting it to use just SequenceDuration it's quite close to the 0.875 value.

@AdamTadeusz AdamTadeusz requested a review from a team July 9, 2024 09:06
@nullsystem nullsystem merged commit 12395b0 into NeotokyoRebuild:master Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants