Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ClientScheme_Neo with ClientScheme #516

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Replace ClientScheme_Neo with ClientScheme #516

merged 1 commit into from
Jul 22, 2024

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jul 20, 2024 •
edited
Loading

Description

  • Merged in whatever ClientScheme_Neo has into ClientScheme
  • Remove neoscheme loading
  • Kept the workaround loading for center hud as it still applies

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

@nullsystem nullsystem changed the title Replace ClientScheme_Neo with ClientScheme WIP: Replace ClientScheme_Neo with ClientScheme Jul 20, 2024
@nullsystem
Replace ClientScheme_Neo with ClientScheme
c468753 
* Merged in whatever ClientScheme_Neo has into ClientScheme
* fixes NeotokyoRebuild#515
@nullsystem nullsystem marked this pull request as ready for review July 20, 2024 15:43
@nullsystem nullsystem requested a review from a team July 20, 2024 15:43
@nullsystem nullsystem changed the title WIP: Replace ClientScheme_Neo with ClientScheme Replace ClientScheme_Neo with ClientScheme Jul 20, 2024
brysondev
brysondev approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@nullsystem nullsystem requested a review from a team July 20, 2024 17:18
@nullsystem nullsystem merged commit 3578f5d into NeotokyoRebuild:master Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glubsy glubsy glubsy approved these changes

@brysondev brysondev brysondev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ClientScheme_Neo.res with ClientScheme.res
3 participants
@nullsystem @glubsy @brysondev