Fix report pathing and re-run tests #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumebert
requested changes
Apr 20, 2021
|
Kudos, SonarCloud Quality Gate passed! |
guillaumebert
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix issue with path separators as reported by Issue #174
Why?
On Windows machines, path separator wasn't being taken into account as a backslash.
How?
Check all system path separators in relative resource URIs for report templates so that no matter which system it is run on, the resource namespace is derived from the relative path (i.e. tests/resources/jinja/builtin_transactions_csv.j2) properly.
Testing
Installed on a Win2016 server and verified working now manually. All other unit tests passing. Also, updated two docker-based tests to be run under the same [integration] model as the other tests which rely on Docker, so that unit test suite passes if Docker is not installed or running.
Additional Notes
This is another thing that would be caught by unit and integration tests if we start using an additional Windows build node in the build and test workflows. Closes #174