Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added color css classes #112

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Added color css classes #112

merged 1 commit into from
Feb 3, 2015

Conversation

russellquinn
Copy link
Contributor

Fix support for the color option by adding css styles for editor window.

Nerian added a commit that referenced this pull request Feb 3, 2015
@Nerian Nerian merged commit 4371f38 into Nerian:master Feb 3, 2015
@Nerian
Copy link
Owner

Nerian commented Feb 3, 2015

Awesome, thanks! Version 0.3.3.4 has been released

@Nerian
Copy link
Owner

Nerian commented Feb 3, 2015

Do you have a non minified version of your changes?

@Nerian
Copy link
Owner

Nerian commented Feb 3, 2015

I have updated the code so that it uses a non-minified version of the assets. Hopefully this will make it easier to set up automatic code changes.

This is how I fixed #100 :

file_path = 'vendor/assets/javascripts/bootstrap-wysihtml5/templates.js'
file = File.read(file_path)
file = file.gsub('<input value=\"http://\" class=\"bootstrap-wysihtml5-insert-image-url form-control\">', '<input value=\"http://\" class=\"bootstrap-wysihtml5-insert-image-url form-control\" data-wysihtml5-dialog-field=\"src\">')
File.write(file_path, file)

These changes are not released in a gem yet because they don't include your changes here.

I would like the changes in this PR to follow the same pattern, that way is automatically done every time I update assets. Would like to do it?

Thanks!

@Nerian
Copy link
Owner

Nerian commented Feb 20, 2015

Fixes at ae0fbd4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants