This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Backend API change pre-work #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkimballn1
requested review from
diyessi,
jbobba,
Krovatkin,
sasadep,
shssf and
silee2
as code owners
jbobba
approved these changes
Nov 15, 2018
shssf
approved these changes
Nov 15, 2018
avijit-nervana
suggested changes
Nov 15, 2018
avijit-nervana
approved these changes
Nov 15, 2018
mbrookhart
approved these changes
Nov 16, 2018
silee2
approved these changes
Nov 16, 2018
sasadep
approved these changes
Nov 19, 2018
postrational
approved these changes
Nov 19, 2018
apwojcik
approved these changes
Dec 5, 2018
diyessi
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pre-work for the Backend API update.
The Backend::compile() call is changed from
to
where Handle will ultimately be an opaque handle but currently is just a
shared_ptr<Function>The big change in this PR is that you now must call
compile()before you callcall()The unit test changes are just to call
compilebefore callingcall. It is a lot of changes in a lot of files, but it really is just the same change over and over.