This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
refactor topological_sort to use Node.get_users() #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diyessi
approved these changes
Mar 2, 2019
rkimballn1
suggested changes
Mar 3, 2019
|
@rkimballn1 I also found and fixed a few places in graph_util.cpp that used |
|
@rkimballn1 Bob, please review again. |
rkimballn1
approved these changes
Mar 8, 2019
|
This PR is fully reviewed. Re-requested @louisfeng review by mistake. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacing deprecated functions:
Node.get_outputs()get_users()wraps get_output_size and get_output_inputs and returns a NodeVector