Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

refactor topological_sort to use Node.get_users() #2536

Merged
merged 6 commits into from
Mar 9, 2019
Merged

refactor topological_sort to use Node.get_users() #2536

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9b578a
use Node.get_users() to replace deprecated func
Mar 1, 2019
a229767
use const ref instead of auto
Mar 4, 2019
05b3f09
used const auto& in graph_util.cpp
Mar 4, 2019
c00f757
Merge branch 'master' into wenzhe/topo_sort_refactor
diyessi Mar 8, 2019
44e7088
Merge branch 'master' into wenzhe/topo_sort_refactor
rkimballn1 Mar 8, 2019
06ee142
Merge branch 'master' into wenzhe/topo_sort_refactor
rkimballn1 Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions src/ngraph/graph_util.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,11 @@ namespace ngraph
result_list.push_back(node_map[independent_node]);
independent_nodes.pop_front();

for (auto& output : independent_node->get_outputs())
for (auto user : independent_node->get_users())
rkimballn1 marked this conversation as resolved.
Show resolved Hide resolved
{
for (auto& input : output.get_inputs())
if (--node_dependency_count[user.get()] == 0)
{
auto user = input->get_raw_pointer_node();
node_dependency_count[user] -= 1;
size_t count = node_dependency_count[user];
if (count == 0)
{
independent_nodes.push_back(user);
}
independent_nodes.push_back(user.get());
}
}

Expand Down Expand Up @@ -179,17 +173,11 @@ namespace ngraph
result_list.push_back(node_map[independent_node]);
independent_nodes.pop_front();

for (auto& output : independent_node->get_outputs())
for (auto user : independent_node->get_users())
{
for (auto& input : output.get_inputs())
if (--node_dependency_count[user.get()] == 0)
{
auto user = input->get_raw_pointer_node();
node_dependency_count[user] -= 1;
size_t count = node_dependency_count[user];
if (count == 0)
{
independent_nodes.push_back(user);
}
independent_nodes.push_back(user.get());
}
}

Expand Down